Repository navigation
Switch from bnd:jar to bnd:bnd-process (#69) - #77
Merged
Merged
Conversation
# Conflicts: # src/site/_release-notes/_10.x.x.adoc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements #69 requesting the switch from
bnd:jartobnd:bnd-process.Implementation notes
spotbugs-maven-pluginstarted crashing with switch tobnd:bnd-process. Settingforktofalsefixed the problem. Though this interestingly caused new bug discoveries byspotbugs:spotbugsgoal and this only happened for2.xbranch.maindid not observe anyspotbugs:spotbugsanomalies after the switch. All new Spotbugs findings in2.xare fixed in apache/logging-log4j2@15fddad and apache/logging-log4j2@9f7455a.useModulePathtofalseformaven-compiler-plugin(withdefault-testCompileexecution ID),maven-surefire-plugin, andmaven-failsafe-plugin. This was already more or less the norm in logging-log4j2.Results
2.xbranch of logging-log4j2 compiles and one can run tests in IntelliJ IDEA without problems.mainbranch of logging-log4j2<extensions>true</extensions>needs to be removed from existingbnd-maven-pluginoverrides.log4j-core) withmodule not found: org.jctools.core,module not found: org.fusesource.jansi, etc. messages.