Repository navigation
Disable -jpms-multi-release BND option - #96
Merged
Merged
Conversation
ppkarwasz
force-pushed
the
93_disable_jpms_multi_release
branch
2 times, most recently
from
January 10, 2024 19:39
eaed378 to
fb6252c
Compare
vy
approved these changes
Jan 11, 2024
vy
left a comment
vy
left a comment
Member
There was a problem hiding this comment.
LGTM. I will appreciate it if we can drop a comment for those who later might attempt to place -jpms-multi-release option back again.
Add rule to ban wildcard imports. Wildcard imports are often the only difference between branches and they can not easily be expanded by Spotless. Fixes #63.
This adds [`jspecify`](https://jspecify.dev/) to the dependency management, a common effort of multiple Java tool developers to provide a common set of nullability annotations. Fixes apache#88.
We add a `maven-clean-plugin` execution to remove any trailing `module-info.class` files before each compilation. Such files can cause problem like in: https://github.com/copernik-eu/bug-reproducibility/tree/main/javac-module-info-bug
Due to limitations of BND 6.x and the build process of our multi-release JARs, this option was never effective. We could reenable it in multi-release JARs that have a difference in package and module dependencies between Java versions.
Co-authored-by: Volkan Yazıcı <[email protected]>
ppkarwasz
force-pushed
the
93_disable_jpms_multi_release
branch
from
January 11, 2024 09:35
b2562fa to
e789acd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to limitations of BND 6.x and the build process of our multi-release JARs, this option was never effective.
We could reenable it in multi-release JARs that have a difference in package and module dependencies between Java versions.
Closes #93.