Skip to content

Aligns the properties for Surefire - #579

Merged
Bukama merged 1 commit into
apache:masterfrom
Bukama:alignsurefire
May 26, 2026
Merged

Bukama merged 1 commit into
apache:masterfrom
Bukama:alignsurefire

Conversation

@Bukama

@Bukama Bukama commented May 17, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@Bukama
Bukama requested a review from slawekjaranowski May 17, 2026 15:17
@Bukama Bukama self-assigned this May 17, 2026
@Bukama

Bukama commented May 17, 2026

Copy link
Copy Markdown
Contributor Author

I was tempted to remove the property at all and label the PR as "breaking", but on the other site I'm not sure if its worth.

@Bukama
Bukama merged commit 806f1ab into apache:master May 26, 2026
3 checks passed
@Bukama
Bukama deleted the alignsurefire branch May 26, 2026 15:53
@github-actions github-actions Bot added this to the 39 milestone May 26, 2026

@ctubbsii ctubbsii left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change (and whatever previous change broke it) completely misunderstands the purpose of the properties.

The whole point of having the surefire.version property above the others was to use that one to sync up the others. The ones that start with version. are immediately followed by the specific artifact that they control. The ones above that, like the surefire.version one, were supposed to be the independent ones that control multiple, to keep them synchronized.

I will submit a new PR to fix this properly, since it looks like this is already merged and possibly already included in a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants