Repository navigation
add push-to-atr profile - #584
Conversation
| <plugin> | ||
| <groupId>org.apache.tooling</groupId> | ||
| <artifactId>atr-maven-plugin</artifactId> | ||
| <version>${version.tooling.atr}</version> |
There was a problem hiding this comment.
I would like to push version in pluginManagement
There was a problem hiding this comment.
uh? why different from everything else?
(I'm the one who fights usually for that: why now and only for that plugin?)
There was a problem hiding this comment.
If some of project wants to extends configuration will not need to declare version for plugin
There was a problem hiding this comment.
oh, you mean keep the property "as usual", but split plugin version declaration vs execution
adding a commit would have saved us time and energy: we need to find easier ways to do PR review that is more collaborative coding than real just review and discuss against original code proposal
| See ATR's {{{https://release-test.apache.org/tutorial}tutorial}} for a quick introduction: you'll have to create a | ||
| project, for example using | ||
| {{{https://github.com/apache/infrastructure-asfyaml/blob/main/README.md#project}<<<project>>> entry in <<<.asf.yaml>>>}}, | ||
| and start the release in ATR before composing. |
There was a problem hiding this comment.
maybe - before upload
we need manually start a new release in ATR before upload files, or we can use atr.createVersion
There was a problem hiding this comment.
don't hesitate to add a commit: phrasing is better by reworking together, not ping-pong comments
| Since release 39, <<<push-to-atr>>> profile is provided to help upload built release content to | ||
| {{{https://tooling.apache.org/}Apache Tooling}}'s Trusted Releases platform, and compose the release | ||
| using {{{https://apache.github.io/tooling-atr-maven-plugin/}<<<atr-maven-plugin>>>}}. |
There was a problem hiding this comment.
by default we only help to upload files other steps need to done in ATR before release start
There was a problem hiding this comment.
same as previous: don't get what action you expect from that comment
| {{{https://tooling.apache.org/}Apache Tooling}}'s Trusted Releases platform, and compose the release | ||
| using {{{https://apache.github.io/tooling-atr-maven-plugin/}<<<atr-maven-plugin>>>}}. | ||
|
|
||
| See ATR's {{{https://release-test.apache.org/tutorial}tutorial}} for a quick introduction: you'll have to create a |
There was a problem hiding this comment.
The main project for a PMC is always present. If a DOAP file is present then the subproject should also exist. Suggest that the user check their committee at https://release-test.apache.org/committees
|
notice: staging resulting doc is visible at https://maven.apache.org/pom-archives/asf-LATEST/#the-push-to-atr-profile |
| </goals> | ||
| <configuration> | ||
| <files> | ||
| <file>${project.build.directory}/${project.artifactId}-${project.version}-source-release.zip</file> |
There was a problem hiding this comment.
I realize this is already merged and I'm late to review, but hard-coding the paths to upload in the plugin config seems like a problem if the hard-coded path is a zip file. zip files don't preserve POSIX execute bits on scripts and other contents, so many projects create a source-release tarball instead, which is configurable in the maven-release-plugin configuration in this parent POM. Any ATR plugin profile should also be similarly capable of being able to handle that.
| <configuration> | ||
| <files> | ||
| <file>${project.build.directory}/${project.artifactId}-${project.version}-source-release.zip</file> | ||
| <file>${project.build.directory}/${project.artifactId}-${project.version}-source-release.zip.sha512</file> |
There was a problem hiding this comment.
Is this supposed to be the sha512 generated by the net.nicoulaj.maven.plugins:checksum-maven-plugin ? That plugin generates checksums for all artifacts with the classifier source-release, not a specific source-release zip file. This plugin config makes a lot of assumptions about the file name of the source-release artifact.
4 participants
as planned and tested during first release in https://github.com/apache/tooling-atr-maven-plugin/blob/atr-maven-plugin-1.0.0-alpha-1/pom.xml#L492