Skip to content

[MASSEMBLY-986] Minimal default Manifest configuration of jar archiver should be respected - #134

Merged
slawekjaranowski merged 4 commits into
masterfrom
MASSEMBLY-986
May 3, 2023
Merged

[MASSEMBLY-986] Minimal default Manifest configuration of jar archiver should be respected#134
slawekjaranowski merged 4 commits into
masterfrom
MASSEMBLY-986

Conversation

@slawekjaranowski

@slawekjaranowski slawekjaranowski commented Apr 23, 2023

Copy link
Copy Markdown
Member

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MASSEMBLY-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MASSEMBLY-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

michael-o
michael-o reviewed Apr 23, 2023
View reviewed changes
Comment thread src/main/java/org/apache/maven/plugins/assembly/archive/DefaultAssemblyArchiver.java Outdated
michael-o
michael-o reviewed Apr 23, 2023
View reviewed changes
Comment thread src/main/java/org/apache/maven/plugins/assembly/archive/DefaultAssemblyArchiver.java Outdated
@michael-o

michael-o commented Apr 23, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

I am still not fully convinced here. For me the gain is questionable or I don't understand it completely. I'd like to hear @hboutemy's opinion on this.

@michael-o
michael-o requested review from hboutemy and michael-o April 23, 2023 14:57
@hboutemy

hboutemy commented Apr 26, 2023

Copy link
Copy Markdown
Member

I don't understand what issue we're trying to solve
I don't understand the title of the issue
The only aspect I understand in the Jira issue description is that "it may break Reproducible Builds", but I don't see how: I never have RB broken by something like that (because Plexus Archiver component version is reproducible)

please explain what the problem is (theoretical or in real life) that is being tried to solve

@slawekjaranowski

slawekjaranowski commented Apr 26, 2023

Copy link
Copy Markdown
Member Author

@hboutemy, @michael-o - Similar change was done in apache/maven-archiver@7041fca

Please try to upgrade plexus-archiver - #119 - it is cause of this issue

@michael-o

michael-o commented Apr 26, 2023

Copy link
Copy Markdown
Member

@hboutemy, @michael-o - Similar change was done in apache/maven-archiver@7041fca

Please try to upgrade plexus-archiver - #119 - it is cause of this issue

Give me a couple of days to look into. I am currently overloaded.

@slawekjaranowski

slawekjaranowski commented Apr 29, 2023

Copy link
Copy Markdown
Member Author

@hboutemy can you update your comment - is it more understandable for you now?

@hboutemy

hboutemy commented May 2, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

IIUC, what you are trying to achieve is to avoid Reproducible Builds output to change when changing plexus-archiver version (like proposed by dependabot in #119 ) because it requires to update the checksums in IT, which is cumbersome

@hboutemy hboutemy changed the title [MASSEMBLY-986] Minimal default Manifest should be used by jar archiver [MASSEMBLY-986] Minimal default Manifest configuration of jar archiver should be respected May 2, 2023
hboutemy
hboutemy requested changes May 2, 2023
View reviewed changes
Comment thread src/main/java/org/apache/maven/plugins/assembly/archive/DefaultAssemblyArchiver.java
Comment thread src/main/java/org/apache/maven/plugins/assembly/archive/DefaultAssemblyArchiver.java Outdated
@slawekjaranowski

slawekjaranowski commented May 2, 2023

Copy link
Copy Markdown
Member Author

Now PR contains only required changes to achieve goal.

hboutemy
hboutemy approved these changes May 3, 2023
View reviewed changes

@hboutemy hboutemy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slawekjaranowski
slawekjaranowski merged commit 2d61b0f into master May 3, 2023
@slawekjaranowski
slawekjaranowski deleted the MASSEMBLY-986 branch May 3, 2023 21:29
@jira-importer

jira-importer commented Jun 17, 2025

Copy link
Copy Markdown

Resolve #1185

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hboutemy hboutemy hboutemy approved these changes
@slachiewicz slachiewicz Awaiting requested review from slachiewicz
@michael-o michael-o Awaiting requested review from michael-o

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@slawekjaranowski @michael-o @hboutemy @jira-importer