Skip to content

declare dependencies - #14

Merged
elharo merged 1 commit into
masterfrom
aether
Jul 22, 2020
Merged

declare dependencies#14
elharo merged 1 commit into
masterfrom
aether

Conversation

@elharo

@elharo elharo commented Jul 22, 2020

Copy link
Copy Markdown
Contributor

@elharo
elharo merged commit 0c87def into master Jul 22, 2020
@elharo
elharo deleted the aether branch July 22, 2020 16:18
@slachiewicz

slachiewicz commented Jan 24, 2021

Copy link
Copy Markdown
Member

Any reason why we need to declare these dependencies? org.eclipse.sisu.plexus is a transitive dependency from maven plugin API
and with each update to minimum maven.version property someone needs to adjust also this one instead of giving Maven chance to do its job.

@elharo

elharo commented Jan 24, 2021

Copy link
Copy Markdown
Contributor Author

If one specifically imports classes from these dependencies, then they should be declared. Relaying on transitive dependencies is brittle. 5 months later I don't recall exactly which classes are imported from where but mvn dependency:analyze will find anything that's not needed.

@dennisl

dennisl commented Jan 25, 2021

Copy link
Copy Markdown
Contributor

I agree with @elharo

@slachiewicz

slachiewicz commented Jan 25, 2021

Copy link
Copy Markdown
Member

thx @dennisl - would you be able to sync the maven version to 3.1.1 as try to confirm that this proposed approach works?

@slachiewicz

slachiewicz commented Jan 25, 2021

Copy link
Copy Markdown
Member 
[INFO] --- maven-dependency-plugin:3.1.1:analyze (default-cli) @ maven-filtering ---
[WARNING] Used undeclared dependencies found:
[WARNING]    org.hamcrest:hamcrest:jar:2.2:test
[WARNING]    org.eclipse.aether:aether-api:jar:0.9.0.M2:compile
[WARNING] Unused declared dependencies found:
[WARNING]    org.hamcrest:hamcrest-core:jar:2.2:test

@slachiewicz

slachiewicz commented Jan 25, 2021

Copy link
Copy Markdown
Member

With each minimum Maven upgrade, someone needs to review all deps and update the version of aether to match with that will be delivered by Maven installation. No older, no newer.

@slachiewicz

slachiewicz commented Jan 25, 2021

Copy link
Copy Markdown
Member

real case: GoogleCloudPlatform/cloud-opensource-java#1091

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dennisl dennisl dennisl approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@elharo @slachiewicz @dennisl