Repository navigation
Conversation
elharo
changed the title
elharo
marked this pull request as ready for review
May 19, 2023 13:33
Member
|
I don't understand this. If a direct dep uses the wrong version then there is the place to fix? Or do we have a conflict in trans deps here? |
Contributor
Author
|
See https://hamcrest.org/JavaHamcrest/distributables for the detailed explanation. This is a weird case that crops up when using JUnit 4 with Hamcrest 2 because Hamcrest moved classes around between artifacts in version 2. Without this JUnit 4 will pull hamcrest-core 1.4.x into the tree, which contains some of the same classes as org.hamcrest:hamcrest:2.2. This can cause split package issues. In 2.2 hamcrest-core is an empty jar to override this. |
michael-o
approved these changes
May 19, 2023
slachiewicz
added
dependencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes dependency warning but still selects the right version of hamcrest-core in transitive dependencies. See https://hamcrest.org/JavaHamcrest/distributables