Repository navigation
[MSHARED-1273] clean up API doc and exceptions - #158
Merged
Merged
Conversation
slachiewicz
approved these changes
Jun 18, 2023
slawekjaranowski
approved these changes
Jun 18, 2023
Member
|
Maybe commit message should contain ... |
Member
|
so it will be breaking change |
Contributor
Author
|
It isn't throwing IOException now. This PR brings the throws clauses in sync with what the code was already (not) doing. I was a little surprised this wasn't already a compiler error. There's something I'm not quite seeing here. |
Member
|
external code that use this methods and catch exception will be broken after update |
Contributor
Author
|
You're right. I think I was mixing up catch blocks for unthrown exceptions and throws clauses for unthrown exceptions in my head. I'll send another PR to clean this up. |
Member
|
No problem. You just have to release minor versions and not bugfix |
|
Resolve #330 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
still trying to figure out how best to replace these methods completely