Repository navigation

[MSHARED-685] assert some things - #16

Merged

elharo merged 4 commits into

Feb 24, 2020

elharo commented Feb 23, 2020

Contributor

@michael-o also fixes a couple of FindBugs warnings

elharo added 3 commits

February 23, 2020 17:56


          assert some things

3d01167


          assert some things

eac2d72


          restore asserts

8d00171

elharo requested a review from michael-o

February 23, 2020 23:00

elharo commented Feb 23, 2020

Contributor Author

See https://builds.apache.org/job/maven-box/job/maven-shared-utils/job/i848/3/

Changes:

restore asserts

5 tests failed.
FAILED: org.apache.maven.shared.utils.io.DirectoryScannerTest.windows-jdk14 / Build windows-jdk14 / checkSymlinkBehaviour

Error Message:
null

Stack Trace:
java.lang.AssertionError
at org.apache.maven.shared.utils.io.DirectoryScannerTest.assertAlwaysIncluded(DirectoryScannerTest.java:172)
at org.apache.maven.shared.utils.io.DirectoryScannerTest.checkSymlinkBehaviour(DirectoryScannerTest.java:140)

FAILED: org.apache.maven.shared.utils.io.DirectoryScannerTest.windows-jdk11 / Build windows-jdk11 / checkSymlinkBehaviour

Error Message:
null

Stack Trace:
java.lang.AssertionError
at org.apache.maven.shared.utils.io.DirectoryScannerTest.assertAlwaysIncluded(DirectoryScannerTest.java:172)
at org.apache.maven.shared.utils.io.DirectoryScannerTest.checkSymlinkBehaviour(DirectoryScannerTest.java:140)

FAILED: org.apache.maven.shared.utils.io.DirectoryScannerTest.windows-jdk8 / Build windows-jdk8 / checkSymlinkBehaviour

Error Message:
null

Stack Trace:
java.lang.AssertionError
at org.apache.maven.shared.utils.io.DirectoryScannerTest.assertAlwaysIncluded(DirectoryScannerTest.java:172)
at org.apache.maven.shared.utils.io.DirectoryScannerTest.checkSymlinkBehaviour(DirectoryScannerTest.java:140)

FAILED: org.apache.maven.shared.utils.io.DirectoryScannerTest.windows-jdk7 / Build windows-jdk7 / checkSymlinkBehaviour

Error Message:
null

Stack Trace:
java.lang.AssertionError
at org.apache.maven.shared.utils.io.DirectoryScannerTest.assertAlwaysIncluded(DirectoryScannerTest.java:172)
at org.apache.maven.shared.utils.io.DirectoryScannerTest.checkSymlinkBehaviour(DirectoryScannerTest.java:140)

FAILED: org.apache.maven.shared.utils.io.DirectoryScannerTest.windows-jdk13 / Build windows-jdk13 / checkSymlinkBehaviour

Error Message:
null

Stack Trace:
java.lang.AssertionError
at org.apache.maven.shared.utils.io.DirectoryScannerTest.assertAlwaysIncluded(DirectoryScannerTest.java:172)
at org.apache.maven.shared.utils.io.DirectoryScannerTest.checkSymlinkBehaviour(DirectoryScannerTest.java:140)

michael-o requested changes

View reviewed changes

src/test/java/org/apache/maven/shared/utils/io/DirectoryScannerTest.java Outdated

                       File rootDir = tempFolder.getRoot();
                       File folder1 = new File( rootDir, "folder1" );
-                      folder1.mkdirs();
+                      if (!folder1.mkdirs())

michael-o Feb 24, 2020

Member

spaces please

elharo Feb 24, 2020

Contributor Author

done

src/test/java/org/apache/maven/shared/utils/io/DirectoryScannerTest.java Outdated

                       File folder2 = new File( folder1, "ignorefolder" );
-                      folder2.mkdirs();
+                      if (!folder2.mkdirs())

michael-o Feb 24, 2020

Member

same here

elharo Feb 24, 2020

Contributor Author

done


          add spaces

0c8eb48

michael-o approved these changes

View reviewed changes

michael-o left a comment

Member

Please squash and merge.

elharo merged commit 5769481 into master

elharo deleted the i848 branch

February 24, 2020 15:38

jira-importer commented Jul 3, 2025

Resolve #263

jira-importer mentioned this pull request

[MSHARED-685] DirectoryScanner#checkSymlinkBehaviour() does not use assert* #261

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet