Repository navigation
CommandLineUtils: ensure all pumpers are waited on in try-finally - #399
Merged
Merged
Conversation
desruisseaux
reviewed
Aug 3, 2026
Comment on lines
+277
to
+286
| try { | ||
| if (inputFeeder != null) { | ||
| inputFeeder.waitUntilDone(); | ||
| } | ||
| } finally { | ||
| try { | ||
| outputPumper.waitUntilDone(); | ||
| } finally { | ||
| errorPumper.waitUntilDone(); | ||
| } |
There was a problem hiding this comment.
It works, but if more than one exception is thrown, we see only the last one. It would be possible to keep all of them with catch (Throwable e) and Throwable.addSuppressed(e) calls, but that would make the code more complex (I'm not sure it would be worth). Alternatively, this exception handling could be made easier if the pumpers implement AutoCloseable.
I'm not really suggesting a change. I'm not against deciding that it is not worth to keep all exceptions. Just submitting for your consideration and letting you decide.
Contributor
Author
There was a problem hiding this comment.
Makes sense, but I think I;m going to leave that for a future PR
desruisseaux
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
CommandLineUtils.call(),waitUntilDone()was called oninputFeeder,outputPumper, anderrorPumpersequentially without try-finally (lines 298-303 of the original). If an earlier call threw (e.g.,InterruptedException), the remaining pumpers were never waited on, leaving their threads potentially running.The commented-out code just above (lines 277-297) shows the original author intended a try-finally chain but never enabled it.
Fix: Replaced the sequential calls and the dead commented block with a proper try-finally chain ensuring all three pumpers are waited on regardless of exceptions from earlier ones.
Fixes #398