Repository navigation
Xpp3DomWriter: reject a null dom with a named NullPointerException - #426
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Xpp3DomWriter.writedereferencesdomimmediately, so a null argument already fails with a bareNullPointerExceptionand no indication of which argument was wrong.Objects.requireNonNullnames it, and a test pins the behaviour.The commit is Elliotte Rusty Harold's, cherry-picked from the
fix/xpp3domwriter-null-dombranch he pushed here on 2026-07-01 and never opened as a PR. Authorship is preserved, and the code is unchanged. Opening it because the fix is finished and 3.5.0 is close; happy to hand it back if he would rather carry it himself.No behaviour change beyond the message: the call threw
NullPointerExceptionbefore and still does. It also addsXpp3DomWriterTest, which the class had none of.Xpp3DomWriteris deprecated in 3.5.0, so this is a diagnostics improvement on a class on its way out rather than new investment.Verified:
mvn -B verifyon JDK 17 -> Tests run: 788, Failures: 0, Errors: 0. Spotless clean.This change was created with AI assistance.