Skip to content

Windows 9X is long dead - #74

Merged
slachiewicz merged 1 commit into
masterfrom
shell
Apr 16, 2021
Merged

slachiewicz merged 1 commit into
masterfrom
shell

Conversation

@elharo

@elharo elharo commented Jan 22, 2021

Copy link
Copy Markdown
Contributor

@slawekjaranowski

Copy link
Copy Markdown
Member

Maybe org.apache.maven.shared.utils.cli.shell.CommandShell should be also removed - I don't see usage of it in this project.

@michael-o

Copy link
Copy Markdown
Member

I agree with @slawekjaranowski

@elharo

elharo commented Jan 22, 2021

Copy link
Copy Markdown
Contributor Author

Eventually, yes. However it's public API so I don't want to remove it until it's been deprecated for a while longer and ideally we're ready for a major version bump.

@slawekjaranowski

Copy link
Copy Markdown
Member

I afraid that this never will happened developers don't look for deprecated ...
The same result will be remove it and release next major version.

Looking for this class on GitHub I found 4 repositories where it is used, one of them is archived, two don't have any releases so impact will not be huge.

@elharo

elharo commented Jan 23, 2021

Copy link
Copy Markdown
Contributor Author

I'm not comfortable removing public API without reasonable notice. Sounds like there are existing uses.

@slawekjaranowski

Copy link
Copy Markdown
Member

So please deprecate class with reason.

Another case is that apache components don't have any release plan / calendar so nobody know when next release will be placed.
Also there is no policy about clearing deprecated items.

@michael-o

Copy link
Copy Markdown
Member

@elharo This won't even run in Windows 9x because there isn't Java 7 for.

@elharo

elharo commented Jan 23, 2021

Copy link
Copy Markdown
Contributor Author

That still doesn't mean we should break the build of projects that have this in their tree. Deprecate and warn them. We can take it out in a few releases.

@slachiewicz

slachiewicz commented Feb 3, 2021 •

Copy link
Copy Markdown
Member

CommandShell / Windows 95 was marked as Deprecated with MSHARED-860 in cb448b9 and released with 3.3.3 version.

@MartinKanters

Copy link
Copy Markdown

@elharo I guess we can merge this then, right? Nobody had any objections against your code, apart from that we had to deprecate the classes, which @slachiewicz pointed out was done last year.

@slachiewicz
slachiewicz merged commit 81a813b into master Apr 16, 2021
@elharo
elharo deleted the shell branch April 16, 2021 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants