Repository navigation
[MWAR-453] Require Java 8 - #23
Conversation
|
@slachiewicz Would you mind rebasing your branch to master, now that MWAR-444 and MWAR-450 has been merged. I don't trust myself to do that right now. |
|
I have merged master into this branch to make sure that all the checks are green, which they are now. Do we need someone to review this PR? |
|
@dennisl can you drop the commit which merges master into this branch and do a rebase instead please? |
bmarwell
left a comment
bmarwell
left a comment
There was a problem hiding this comment.
Some open questions, but changes requested mainly due to merge commit.
|
|
||
| // Ok now check that there is no more files/directories | ||
| final FileFilter filter = new FileFilterImpl( webAppDirectory, new String[] { MANIFEST_PATH } ); | ||
| final FileFilter filter = new FileFilterImpl( webAppDirectory, new String[] {MANIFEST_PATH} ); |
|
|
||
| // Ok now check that there is no more files/directories | ||
| final FileFilter filter = new FileFilterImpl( webAppDirectory, new String[] { MANIFEST_PATH } ); | ||
| final FileFilter filter = new FileFilterImpl( webAppDirectory, new String[] {MANIFEST_PATH} ); |
|
|
||
| // Ok now check that there is no more files/directories | ||
| final FileFilter filter = new FileFilterImpl( webAppDirectory, new String[] { MANIFEST_PATH } ); | ||
| final FileFilter filter = new FileFilterImpl( webAppDirectory, new String[] {MANIFEST_PATH} ); |
|
@olamy told me the merge commit will go away due to squashing anyway. Forget my previous comment about dropping and rebasing. |
michael-o
left a comment
michael-o
left a comment
There was a problem hiding this comment.
MANIFEST_PATH issue is still there.
|
Sorry, all changes was done from scratch and looks like Intellij automatically makes this changes |
|
Resolve #525 |
1 similar comment
|
Resolve #525 |
5 participants
No description provided.