Skip to content

[MWRAPPER-86] Trim trailing slash in Repo URL #208

Description

@jira-importer

Björn Michael opened MWRAPPER-86 and commented

If repository URL ends with a trailing slash then the URLs in maven-wrapper.properties contain double slashes.

E.g. MVNW_REPOURL=[https://myrepo.local/] ends up with

distributionUrl=https://myrepo.local//org/apache/maven/apache-maven/3.8.7/apache-maven-3.8.7-bin.zip
wrapperUrl=https://myrepo.local//org/apache/maven/wrapper/maven-wrapper/3.1.1/maven-wrapper-3.1.1.jar

This also occurs when mirror * URL ends with trailing slash.


Affects: 3.1.1

Remote Links:

1 votes, 4 watchers

Activity

  1. jira-importer commented on Jan 3, 2023

    @jira-importer
    Author

    Michael Osipov commented

    Which problem do you experience? According to RFC 3986 this is valid.

  2. jira-importer commented on Jan 3, 2023

    @jira-importer
    Author

    Björn Michael commented

    The URLs were corrected manually after the double slashes were discovered.

    Examples in RFC3986 use single slash syntax. a/b/c and a/b//c technically represent different paths but are irrelevant for repository URL here.

    ??So: yes, it is valid, no, don't use it.??

    https://stackoverflow.com/questions/20523318/is-a-url-with-in-the-path-section-valid

    ??As mentioned by @RandomBen, the double slash is most likely the result of an error somewhere.??
    https://webmasters.stackexchange.com/questions/8354/what-does-a-double-slash-in-the-url-path-mean

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingpriority:majorMajor loss of function

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions