Repository navigation
[MWRAPPER-134] Provide a reliable way to determine the Maven Wrapper version #249
Description
Activity
Damiano Albani commented
Nils Breunese
A couple of my colleagues implemented the support for keeping Maven Wrapper up-to-date in Renovate, and I believe Renovate currently determines the version of Maven Wrapper based on thewrapperUrlproperty, so I think that logic may need to be updated after this change.Do you have information to share about the change in Renovate Bot to support this new "wrapperVersion"?
I couldn't find anything relevant on https://github.com/renovatebot/renovate/.Nils Breunese commented
Damiano Albani See here: renovatebot/renovate#28648. A colleague of mine is willing to work on this, but hasn't found the time for it yet.
Nils Breunese opened MWRAPPER-134 and commented
I use Renovate to automatically keep dependencies up-to-date and I noticed that the upgrade to Maven Wrapper 3.3.0 removed the
wrapperUrlline from{}.mvn/wrapper/maven-wrapper.properties{}. I guess that is related to MWRAPPER-120.A couple of my colleagues implemented the support for keeping Maven Wrapper up-to-date in Renovate, and I believe Renovate currently determines the version of Maven Wrapper based on the
wrapperUrlproperty, so I think that logic may need to be updated after this change. Without thewrapperUrlproperty, I think currently the only option to determine the Maven Wrapper version is parsing themvnw/mvnw.cmdscripts themselves, but that sounds like a clunky and unreliable way.In a discussion on the maven-users mailinglist, the idea was posted to add a dedicated property for this (e.g.
{}wrapperVersion{}), which can be read by external tools.Affects: 3.3.0
Issue Links:
MWRAPPER-120 Maven wrapper plugin should not create wrapperUrl property for script-only mode
MWRAPPER-135 Provide a reliable way to determine the Maven Wrapper type
Remote Links: