Repository navigation
[MWRAPPER-135] Provide a reliable way to determine the Maven Wrapper type #254
Description
Tamas Cservenak opened MWRAPPER-135 and commented
Just like MWRAPPER-134 but for type. I completely forgot about this. As this way, tooling can figure out not only version but type (also for humans, just peek at properties).
Issue Links:
-
MWRAPPER-141 Use distribution type of existing Maven Wrapper by default
-
MWRAPPER-134 Provide a reliable way to determine the Maven Wrapper version
Remote Links:
Activity
jira-importer commentedon May 17, 2024
Nils Breunese commented
Tamas Cservenak I've created a pull request for this feature. Currently the property name is
{}distributionType{}, because that is also what it is called in theWrapperMojoclass internally. Do you think that is the best name, or should it maybe be{}wrapperType{}?jira-importer commentedon May 17, 2024
Nils Breunese commented
Also, if
wrapper:wrapperis run on a project that already contains this property inmaven-wrapper.properties(for instance when updating Maven Wrapper), would it make sense to use this type by default whentypeis not explicitly set via{}-Dtype={}? If so, I guess this can also be implemented via a separate ticket.jira-importer commentedon May 17, 2024
Tamas Cservenak commented
Thanks Nils Breunese