Repository navigation
Conversation
github-actions
Bot
added
Arch: xtensa
Contributor
Author
JianyuWang0623
force-pushed
the
br_wjy_esp32s3_spi_cs_miso_optional_250327
branch
from
March 27, 2025 13:22
448e99f to
f9989d0
Compare
Contributor
|
@JianyuWang0623 I think in some cases MOSI also could be optional, for example ADS7886 requires MISO, SCLK and CS, but doesn't require MOSI. |
The MISO or MOSI pin is optional. The C/S pin is unnecessary when `ESP32S3_SPI_UDCS` is enabled. Signed-off-by: wangjianyu3 <[email protected]>
JianyuWang0623
force-pushed
the
br_wjy_esp32s3_spi_cs_miso_optional_250327
branch
from
March 27, 2025 13:56
f9989d0 to
66c3131
Compare
github-actions
Bot
added
Size: M
Contributor
Author
@acassis Got it, updated, thank you! |
acassis
approved these changes
Mar 27, 2025
lupyuen
approved these changes
Mar 28, 2025
eren-terzioglu
approved these changes
Mar 28, 2025
jerpelea
approved these changes
Mar 28, 2025
4 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The MISO and C/S pins of SPI are optional.
ESP32S3_SPI_UDCSis enabled.Impact
esp32s3
Testing
lckfb-szpi-esp32s3:lcd(not upstreamed yet)