Repository navigation
[improve] [broker] Pin AppendIndexMetadataInterceptor to field in ManagedLedgerInterceptorImpl - #20112
Merged
Technoboy- merged 3 commits intoApr 20, 2023
Conversation
AnonHxy
approved these changes
Apr 17, 2023
Contributor
|
LGTM |
BewareMyPower
approved these changes
Apr 17, 2023
nicoloboschi
requested changes
Apr 17, 2023
nicoloboschi
approved these changes
Apr 17, 2023
…torImpl` to avoid iterate interceptors only to find AppendIndexMetadataInterceptor
…/ManagedLedgerInterceptorImpl.java Co-authored-by: Nicolò Boschi <[email protected]>
Technoboy-
force-pushed
the
pin_append_index_metadata_interceptor
branch
from
April 20, 2023 05:53
943a82b to
1d6de86
Compare
Codecov Report
@@ Coverage Diff @@
## master #20112 +/- ##
=============================================
+ Coverage 33.17% 72.92% +39.74%
- Complexity 12236 31928 +19692
=============================================
Files 1499 1868 +369
Lines 114413 138413 +24000
Branches 12431 15233 +2802
=============================================
+ Hits 37962 100937 +62975
+ Misses 71499 29440 -42059
- Partials 4952 8036 +3084
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This was referenced Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
most method in
ManagedLedgerInterceptorImplis just iterate all the interceptors to find theAppendIndexMetadataInterceptorwhich is unnessary.Modifications
just save
AppendIndexMetadataInterceptorto field when needed just call interceptor directly.Verifying this change
This change is already covered by existing tests, such as (please describe tests).
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: