Repository navigation
Fix ArrayIndexOutOfBoundsException in PerformanceProducer. - #5786
Merged
Merged
Conversation
Contributor
Author
|
run java8 tests |
rdhabalia
reviewed
Dec 3, 2019
|
|
||
| private static Recorder recorder = new Recorder(TimeUnit.SECONDS.toMillis(120000), 5); | ||
| private static Recorder cumulativeRecorder = new Recorder(TimeUnit.SECONDS.toMillis(120000), 5); | ||
| private static Recorder recorder = new Recorder(TimeUnit.SECONDS.toMicros(120000), 5); |
Contributor
There was a problem hiding this comment.
are we changing latency output in microseconds?
Contributor
Author
There was a problem hiding this comment.
Currently, the microseconds was recorded into recorder but output in mills. We can change the record value to mills or change the highestTrackableValue to microseconds. The latter is currently selected
sijie
approved these changes
Dec 4, 2019
Contributor
Author
|
run java8 tests |
jiazhai
approved these changes
Dec 7, 2019
1 of 11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5760
Motivation
We use
org.HdrHistogram.Recorderto record write latency andhighestTrackableValueisTimeUnit.SECONDS.toMicros(120000), but we record the value in micros, the error happens when the latency in micros is a very large number, so this PR change thehighestTrackableValueof Recorder toTimeUnit.SECONDS.toMicros(120000)Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation