Skip to content

Fix comments in config.yaml - #7

Closed
zou000 wants to merge 1 commit into
arrowtype:mainfrom
zou000:patch-1
Closed

zou000 wants to merge 1 commit into
arrowtype:mainfrom
zou000:patch-1

Conversation

@zou000

@zou000 zou000 commented Nov 20, 2020

Copy link
Copy Markdown

No description provided.

@arrowtype

Copy link
Copy Markdown
Owner

Oops, I should have updated those comments after adjusting the stylistic sets. 😬 Nice job figuring it out, and thank you for submitting a PR!

I'll leave it open temporarily as a reminder for myself to verify the accuracy of the stylistic set guidance in this repo overall, then merge it once I'm confident things are all correct.

@seritools

Copy link
Copy Markdown

The predefined configs also still use the old ones, meaning that the distributed releases in the main repo activate the wrong styles:

image

@arrowtype

Copy link
Copy Markdown
Owner

Thanks, @zou000 for flagging this, and thanks @seritools for commenting further.

I needed to update the stylistic set info in a few places, so I did this and built new fonts in c736d86.

So, this PR was helpful, but I’ll close it now that things are solved. Cheers!

@arrowtype arrowtype closed this Nov 28, 2020
@arrowtype

Copy link
Copy Markdown
Owner

PS I have also updated the fonts at https://github.com/arrowtype/recursive/releases/tag/1.066.

Thanks for pointing out that specific error, @seritools!

@zou000

zou000 commented Nov 28, 2020

Copy link
Copy Markdown
Author

Thanks, @zou000 for flagging this, and thanks @seritools for commenting further.

I needed to update the stylistic set info in a few places, so I did this and built new fonts in c736d86.

So, this PR was helpful, but I’ll close it now that things are solved.
Thanks for the fix. You might want to update the image used in the readme as well :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants