Skip to content

ExceptionMixin omits the logger argument for warning messages #120

Description

@bestiasan

The logger argument is missing in self.builder function call:

return self.builder(self.val, self.description, self.kind, ex)

return self.builder(str(e), self.description, self.kind)

return self.builder(self.val, self.description, self.kind, ex , self.logger)

This leads to throwing exceptions if the logger is used in some custom extension.

Additionally, the function when_lated_with does not return AssertionBuilder on invalid type of exception or failure as expected.

No activity

Activity on this issue will appear here.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions