Prioritize human-readable names in CLI output - #25869
Merged
Merged
Conversation
Summary
--
This PR swaps the rule name and code in our `--show-fixes` output, which previously looked like
this:
TODO
and now looks like this in preview:
TODO
The actual code change is just for this one flag, but I also examined the other CLI flags (besides
diagnostic output formats, which I'll update separately) and think that nothing else needs to be
updated. The other two main candidates were `--statistics` and `--show-settings`, but these already
show both codes and names prominently. `--show-settings` even prioritizes them over codes:
```console
❯ ruff check --no-cache --ignore-noqa --statistics
1 F401 [*] unused-import
Found 1 error.
[*] 1 fixable with the `--fix` option.
❯ ruff check --no-cache --show-settings
...
linter.rules.enabled = [
multiple-imports-on-one-line (E401),
module-import-not-at-top-of-file (E402),
...
]
...
```
Test Plan
--
New CLI test and the screenshots above
ntBre
added
cli
ntBre
commented
Jun 11, 2026
| } | ||
|
|
||
| #[test] | ||
| fn show_fixes_preview() -> Result<()> { |
Contributor
Author
There was a problem hiding this comment.
Just noting that we have existing non-preview tests for this flag just above
ntBre
marked this pull request as ready for review
June 11, 2026 15:56
|
MichaReiser
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR swaps the rule name and code in our
--show-fixesoutput, which previously looked likethis:
and now looks like this in preview:
The actual code change is just for this one flag, but I also examined the other CLI flags (besides
diagnostic output formats, which I'll update separately) and think that nothing else needs to be
updated. The other two main candidates were
--statisticsand--show-settings, but these alreadyshow both codes and names prominently.
--show-settingseven prioritizes them over codes:Test Plan
New CLI test and the screenshots above