Repository navigation
[ruff] Allow docstrings in strict mode (RUF067) - #28679
Merged
Merged
Conversation
|
saberoueslati
marked this pull request as ready for review
September 23, 2026 15:58
ntBre
added
rule
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #27416.
With
lint.ruff.strictly-empty-init-modules = true, RUF067 flagged docstrings in__init__.py. Strict mode now allows module and attribute docstrings, as non-strict mode already does. Other code remains flagged, including bare strings that are not docstrings. The rule and option documentation now reflect this behavior.Test Plan
Added a bare string that is not a docstring to the RUF067 fixture and regenerated the snapshots. The snapshots confirm that strict mode permits module and attribute docstrings while flagging the bare string. The focused RUF067 tests pass. I also verified that a docstring-only
__init__.pypasses in strict mode.