Skip to content

Drop oldest supported numpy from build-system - #193

Merged
pllim merged 2 commits into
astropy:mainfrom
WilliamJamieson:bugfix/python-3.12
Aug 18, 2023
Merged

pllim merged 2 commits into
astropy:mainfrom
WilliamJamieson:bugfix/python-3.12

Conversation

@WilliamJamieson

Copy link
Copy Markdown
Contributor

This is superfluous and was never needed.
It appears to have come from copy/paste from the old astropy package template

This is superfluous and was never needed.
It appears to have come from copy/paste from the old astropy package template
@codecov

codecov Bot commented Aug 18, 2023 •

Copy link
Copy Markdown

Codecov Report

Merging #193 (835a0eb) into main (0ab96f6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #193   +/-   ##
=======================================
  Coverage   98.63%   98.63%           
=======================================
  Files          55       55           
  Lines        2046     2046           
=======================================
  Hits         2018     2018           
  Misses         28       28           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pllim pllim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the quick fix!

@pllim
pllim merged commit a53ed69 into astropy:main Aug 18, 2023
@WilliamJamieson
WilliamJamieson deleted the bugfix/python-3.12 branch August 18, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants