You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We need an astropy issue to be addressed, which is currently being addressed by @eteq, before we can move forward on the moon phase, illumination, position calculations.
Once this issue has been addressed, we can bring in this jplephem implementation of get_moon from this toy notebook.
The issue @bmorris3 linked to here actually is not a show-stopper and can be worked around in astroplan... but there's another issue (not yet in the astropy issue tracker because I'm still determining it's exact nature) that will be harder to work around from the outside. So for that issue I agree we'll need to think about how to match astroplan to astropy versions. It may not be an issue if the fix ends up in a bug fix release (i.e. astropy 1.0.4) because then we can just require that.
Activity
cdeil commentedon Jul 21, 2015
I've put "whishlist" as milestone for this.
Probably we want astroplan 0.1 to work with astropy 1.0 and then only require astropy 1.1. later?
eteq commentedon Jul 21, 2015
The issue @bmorris3 linked to here actually is not a show-stopper and can be worked around in astroplan... but there's another issue (not yet in the astropy issue tracker because I'm still determining it's exact nature) that will be harder to work around from the outside. So for that issue I agree we'll need to think about how to match astroplan to astropy versions. It may not be an issue if the fix ends up in a bug fix release (i.e. astropy 1.0.4) because then we can just require that.
bsipocz commentedon May 14, 2016
Since astropy/astropy#4890 is merged this can be closed I think.
bmorris3 commentedon May 15, 2016
This one can be closed when we actually implement the lunar features
moon_altaz,MoonSeparationConstraint, etc using astropy rather than PyEphem.bmorris3 commentedon Aug 4, 2016
This is closed by #167.