Skip to content

Let frames/coordinates have (internal?) has_distance function #10294

Open

Description

@mhvk

In a fair number of places inside our coordinate machinery, we have to deal with coordinates with and without distances, and are testing this somewhat haphazardly - checking whether the representation is UnitSphericalRepresentation or whether it is Spherical and the distance is all unity. We should normalize these tests, and ideally also ensure that the second case simply doesn't happen (so that the test can be very simple).

Activity

  1. CaioCoutinhoP commented on May 9, 2023

    @CaioCoutinhoP
    Contributor

    This issue is still open for contributions?

  2. mhvk commented on May 9, 2023

    @mhvk
    ContributorAuthor

    Yes, it has not been tackled yet. It does require fairly detailed understanding of how about coordinate machinery works, though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions