Skip to content

Stop bundling jquery? #10420

Closed
#17521
Closed
Stop bundling jquery?#10420
#17521
Labels
RefactoringexternalPRs and issues related to external packages vendored with Astropy (astropy.extern)table

Description

@mhvk
mhvk
opened on Jun 1, 2020

While looking at what makes astropy so big (21MB), I wondered about jquery (~1MB). Looking at old issues, I realize it is big in part because we need to include the actual source, but why is it included in the first place? It is used only for table/jsviewer, and that ignores the source if one is on-line. Would it not make more sense to just move it to the "extra" packages, so that users who really use this feature a lot offline can get it if they want? Or is it difficult to install? (I see a jquery on pypi, but that perhaps is not the same thing.)

Ping @taldcroft - for reference, astropy/table itself is also ~1 MB...

Activity

  1. taldcroft commented on Jun 1, 2020

    @taldcroft
    taldcroft
    on Jun 1, 2020
    Member

    I'm ok with not bundling that. Just need to provide some hints on the docs on getting this for offline use.

  2. saimn
    added
    table
    on Jun 1, 2020

  3. saimn commented on Jun 1, 2020

    @saimn
    saimn
    on Jun 1, 2020
    Contributor

    The un-minified files are included because Debian requires that: #4330 (even if they don't use that files: #4330 (comment)).

  4. saimn commented on Jun 1, 2020

    @saimn
    saimn
    on Jun 1, 2020
    Contributor

    And once compressed this is not so big:

    ❯ l astropy/extern/jquery/data/js/               
total 876K
-rw-r--r-- 1 sconseil 261K Oct  3  2019 jquery-3.1.1.js
-rw-r--r-- 1 sconseil  85K Oct  3  2019 jquery-3.1.1.min.js
-rw-r--r-- 1 sconseil 437K Oct  3  2019 jquery.dataTables.js
-rw-r--r-- 1 sconseil  81K Oct  3  2019 jquery.dataTables.min.js

❯ gzip astropy/extern/jquery/data/js/*

❯ l astropy/extern/jquery/data/js/    
total 252K
-rw-r--r-- 1 sconseil  78K Oct  3  2019 jquery-3.1.1.js.gz
-rw-r--r-- 1 sconseil  30K Oct  3  2019 jquery-3.1.1.min.js.gz
-rw-r--r-- 1 sconseil 110K Oct  3  2019 jquery.dataTables.js.gz
-rw-r--r-- 1 sconseil  28K Oct  3  2019 jquery.dataTables.min.js.gz

    Also jquery on PyPI is something else, a TurboGears plugin released on 2008.

  5. mhvk commented on Jun 1, 2020

    @mhvk
    mhvk
    on Jun 1, 2020
    ContributorAuthor

    OK, still I guess the question remains why we ship something that mostly does not get used.

  6. pllim
    added
    externalPRs and issues related to external packages vendored with Astropy (astropy.extern)
    Refactoring
    on Jul 9, 2020
  7. pllim
    closed this as completedin #17521on Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    RefactoringexternalPRs and issues related to external packages vendored with Astropy (astropy.extern)table

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions