Skip to content

Make _fitter_to_model_params public available to all users #11735

Closed

Description

@mcara

When subclassing fitters in order to override the objective_function method, one needs to use _fitter_to_model_params (or, alternatively implement a long hack). It is unfortunate that this function is "private" (_) and this poses some dangers when subclassing this class.

Would it be possible to make it public?

Activity

  1. WilliamJamieson commented on Dec 10, 2021

    @WilliamJamieson
    Contributor

    @mcara, I have also run into this issue a few times, so I have created a PR which makes them public.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions