Allow frames to set a default wrap angle for longitudes #11767

Activity

1. mhvk

   added

   Feature Request

   coordinates

   on May 21, 2021
2. mkbrewer commented on May 21, 2021

   

   mkbrewer

   on May 21, 2021

   Last edited by mkbrewer

   Contributor

   More actions

   I should think that the required range should be inherent in the definition of units.hourangle.
   Never mind.
3. ayshih commented on May 21, 2021

   

   ayshih

   on May 21, 2021

   Contributor

   More actions

   Since you mentioned SunPy, here's a reminder for how we've implemented it in our base frame (sunpy/sunpy#3223, inspired by #7462 (comment)):

   https://github.com/sunpy/sunpy/blob/e0289b1aae66c667c43e36a306ba274b666fbfd4/sunpy/coordinates/frames.py#L141-L148

       def represent_as(self, base, s='base', in_frame_units=False):
           data = super().represent_as(base, s, in_frame_units=in_frame_units)
   
           # If a frame wrap angle is set, use that wrap angle for any spherical representations.
           if self._wrap_angle is not None and \
              isinstance(data, (UnitSphericalRepresentation, SphericalRepresentation)):
               data.lon.wrap_angle = self._wrap_angle
           return data

   Any of our frame classes can change the inherited class variable _wrap_angle from its default value of 180 degrees.