You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the Dev Telecon today we discussed #9676. Building on top of that, the suggestion is to add a CI bot to check that the PR checklist is all checked.
The bot should probably be "allowed-fail".
Require PR authors to write “What’s new” for major features? https://github.com/astropy/astropy/issues/9676
Do we want that? Where do we say so? Suggestion: Add to the PR checklist “[ ] What’s new? entry included in PR (if warranted)”?
The discussion in the issue is stalled, so it seems good to bring it up here to make a decision or suggestion on how to proceed.
Next steps:
Open Issue for: Bot for Checklist is completely checked? Allowed-fail bot
@saimn , @Cadair , and I discussed this today and we decided that maybe this has crossed the line a little bit. This might discourage contributors/reviewers from small PRs. There is also a circular problem of the CI checkbox, this check that checks the CI checkbox, and maintainer cannot check the CI checkbox until CI passes but CI won’t pass if the checkbox is not checked. ♻️
Therefore, I propose closing this request as won't fix (even though I did suggest it in the first place).
Hi humans 👋 - this issue was labeled as Close? approximately 5 hours ago. If you think this issue should not be closed, a maintainer should remove the Close? label - otherwise, I will close this issue in 7 days.
If you believe I commented on this issue incorrectly, please report this here
I'm going to close this issue as per my previous message, but if you feel that this issue should stay open, then feel free to re-open and remove the Close? label.
If this is the first time I am commenting on this issue, or if you believe I closed this issue incorrectly, please report this here
Activity
pllim commentedon Feb 10, 2022
@saimn , @Cadair , and I discussed this today and we decided that maybe this has crossed the line a little bit. This might discourage contributors/reviewers from small PRs. There is also a circular problem of the CI checkbox, this check that checks the CI checkbox, and maintainer cannot check the CI checkbox until CI passes but CI won’t pass if the checkbox is not checked. ♻️
Therefore, I propose closing this request as won't fix (even though I did suggest it in the first place).
github-actions commentedon Feb 11, 2022
Hi humans 👋 - this issue was labeled as Close? approximately 5 hours ago. If you think this issue should not be closed, a maintainer should remove the Close? label - otherwise, I will close this issue in 7 days.
If you believe I commented on this issue incorrectly, please report this here
github-actions commentedon Feb 19, 2022
I'm going to close this issue as per my previous message, but if you feel that this issue should stay open, then feel free to re-open and remove the Close? label.
If this is the first time I am commenting on this issue, or if you believe I closed this issue incorrectly, please report this here