Repository navigation
Construct ndarray/MaskedArray subclasses that can be re-used throughout astropy? #1857
Description
In #1852, I suggested
... the above made me wonder whether for internal use we should simply make our own MaskedArray subclass in which we override some of the behaviour; this helps make sure we do not have to take the peculiarities into account in every subclass we construct (the comments in MaskedColumn show this has been a fun aspect...), and will also make it easier to send PRs to numpy (I saw @taldcroft had a few, and I've been making some myself as well).
Aside: from my last PR it is clear the numpy people would like to move MaskedArray to the new array_ufunc functionality (which will be a big benefit for Quantity as well). This is a chance to help get the implementation right.
The ding-ding-ding in #1471 made me feel this probably is something we should do -- hence I decided to make it its own issue.
EDIT (2014-01-17): Possibly, we should even have our own ndarray subclass, as this would help with, e.g., pickling of additional attributes (see #1961).
Activity
taldcroft commentedon Dec 2, 2013
@mhvk - I'm starting to see some merit in this idea!
astrofrog commentedon Mar 15, 2014
@mhvk - sorry that I didn't get to reply to this sooner. I think this would be a great idea. Do you want to give it a shot to see what this would look like? Maybe this should go in
astropy.utils, possiblyastropy.utils.numpy. What do you think?mhvk commentedon Jan 13, 2015
Milestone cleared here, as I think this is more of a wish-list feature. I did have a fair start (see https://github.com/mhvk/astropy/compare/util-masked-array, especially the test cases), but lost steam, not helped by not really needing the masked arrays myself...
nstarman commentedon May 20, 2021
@mhvk, close this issue?
mhvk commentedon May 20, 2021
yes, superseded by #11127