Repository navigation
#3389 breaks an affiliated package #3478
Description
pyasdf's setup.py ends up importing astropy.units for reasons that aren't entirely good (so I plan to fix that). But this worked until #3389, when astropy.units is no longer importable during setup, because:
When _ASTROPY_SETUP_ is in builtins (it's set in the setup.py in the package template) [1] the NUMPY_LT_X_X constants don't get imported into astropy.utils.compat [2], then when astropy.units.quantity tries to use one of those constants [3], it blows up.
[1] https://github.com/astropy/package-template/blob/master/setup.py#L16
[2] https://github.com/astropy/astropy/blob/master/astropy/utils/compat/__init__.py#L13
[3] https://github.com/astropy/astropy/blob/master/astropy/units/quantity.py#L24
Not sure how to resolve this other than requiring affiliated packages to be "careful":
There seems to be only one case where _ASTROPY_SETUP_ matters to affiliated packages:
https://github.com/astropy/astropy/blob/master/astropy/config/configuration.py#L665
Maybe we use a different variable for "affiliated package setup" vs. "astropy setup"?
Activity
embray commentedon Feb 10, 2015
I was a little bothered about the fact that those constants are undefined in that context. But it didn't break Astropy itself so I forged ahead. And it made sense as it was, since in
_ASTROPY_SETUP_it's assumed that dependencies like Numpy might not be available.What I could do is enhance the
minversionfunction to accept a module name as a string instead of (or in addition to) an actual module object. Then it can handle the importing of that module, and if that fails just return False (since obviously the minimum version requirement has not been satisfied if the dependency doesn't exist at all).mhvk commentedon Feb 11, 2015
@embray - I think the fix in #3479 is reasonable, but your logic above is not: if
minversionreturnsFalseif the import fails, then all the stringsNUMPY_LT_..., which are defined as somenot minversion(...)will returnTrue. Logically, I think one should letImportErrorbe raised.