Skip to content

Astropy data mirror download infrastructure is not robust #6061

Closed

Description

@pllim

Even with #5547, I still see timeouts. Will more mirrors fix this problem or should we revive #5994?

Activity

  1. bsipocz commented on Jun 7, 2018

    @bsipocz
    Member

    Here are another examples of the URL issues: https://circleci.com/gh/astropy/astropy/8682?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

    https://travis-ci.org/astropy/astropy/jobs/389046646

    @astrofrog as already mentioned somewhere that it's very unlikely that both the astropy data server and the github mirror fail at the same time, so this may be a symptom of a bug with the download infrastructure.

  2. changed the title [-]Add more Astropy data mirrors?[/-] [+]Astropy data mirror download infrastructure is not robust[/+] on Jun 7, 2018
  3. pllim commented on Jun 7, 2018

    @pllim
    MemberAuthor

    Come to think of it, I wonder if it is the test itself that is flawed. Consider this:

        def test_download_parallel():
            # ...
            main_url = 'http://data.astropy.org/intersphinx/README'
            mirror_url = 'http://www.astropy.org/astropy-data/intersphinx/README'
            fnout = download_files_in_parallel([
    >           'http://data.astropy.org', main_url, mirror_url])

    This test is set up to hit data.astropy.org twice and also www.astropy.org at the same time. Maybe that sometimes trigger some server-side panic? Will have to think about this some more...

  4. mhvk commented on Jun 13, 2018

    @mhvk
    Contributor

    Yes, have been seeing fairly regular timeouts again...

  5. astrofrog commented on Jun 13, 2018

    @astrofrog
    Member

    I agree that there must be some bug hiding in the mirror infrastructure. Note that the easiest way to simulate an issue with the primary server is to edit your /etc/hosts file and add:

    127.0.0.1       data.astropy.org
    
  6. pllim commented on Jun 14, 2018

    @pllim
    MemberAuthor

    @mhvk do you mean just the test_download_parallel or some other ones as well?

  7. mhvk commented on Jun 14, 2018

    @mhvk
    Contributor

    @pllim - I fear I have not looked carefully. It is just that regularly there is a failing travis tests, and scrolling to the bottom I see a URL timeout, so I restart. It would be very nice if this were not necessary.

    One thing that is odd is that I only see this on travis - do the others not do any remote tests? Or does that mean it is the all-remote tests that usually fail.

  8. pllim commented on Jun 14, 2018

    @pllim
    MemberAuthor

    do the others not do any remote tests?

    Appveyor does not. CircleCI only does remote tests for visualization.

  9. bsipocz commented on Jun 15, 2018

    @bsipocz
    Member

    And circleCI fails with those downloads regularly, too.

  10. astrofrog commented on Jun 18, 2018

    @astrofrog
    Member

    I'll try and investigate this

  11. astrofrog commented on Jun 18, 2018

    @astrofrog
    Member

    See #7573 for a coupe of failures (including the one from @pllim in #6061 (comment)) that happen consistently if you 'turn off' one of the servers. The issue with that specific test is that it's flawed - it will only pass if both the main server and the mirror work.

  12. pllim commented on Jun 18, 2018

    @pllim
    MemberAuthor

    Yeah... I think that is my bad (#6987)... I'll fix it...

  13. pllim commented on Jun 21, 2018

    @pllim
    MemberAuthor

    Everyone... Hopefully this is fixed. Please re-open if the problem resurfaces. Thanks for your patience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions