Skip to content

Deprecate catch_warnings and raises in favor of pytest machinery? #6761

Closed

Description

@pllim

For example, some catch_warnings can be replaced with pytest.warns (see https://docs.pytest.org/en/latest/warnings.html#warns). As a result, do we still need warning related functionality in astropy/tests/helper.py?

Activity

  1. mhvk commented on Oct 21, 2017

    @mhvk
    Contributor

    I've wondered too whether pytest has caught up with our custom machinery; it would certainly be nice to be as compliant as possible in our tests.

  2. pllim commented on Jun 17, 2020

    @pllim
    MemberAuthor

    Started an attempt at #10504 .

    UPDATE: With that PR merged, we no longer use catch_warnings or raises from helper.py but it doesn't stop them from creeping back in until we start to deprecate them. Deprecation is a battle for another day.

  3. self-assigned this
    on Jun 17, 2020
  4. changed the title [-]Replace warning handlers with pytest machinery?[/-] [+]Deprecate catch_warnings and raises in favor of pytest machinery?[/+] on Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions