You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Move periodogram modules stats to timeseries #8410
@jakevdp, as well as others (especially from stats: @larrybradley@crawfordsm) - Do you have any thoughts on the namespace LombScargle should be available from one this refactoring is done?
from astropy.timeseries import LombScarge
from astropy.timeseries.periodograms import LombScargle
Honestly either way is fine by me, and only pushing to get a decision as then I can update the imports in the astroML textbook (so users don't get deprecation warnings for the new edition).
The main part will be the TimeSeries class, and we plan to move the two periodograms. Not sure moving the bayesian blocks would make much sense, they are more generic stats tools then these.
Activity
bsipocz commentedon Feb 11, 2019
@jakevdp, as well as others (especially from stats: @larrybradley @crawfordsm) - Do you have any thoughts on the namespace
LombScargleshould be available from one this refactoring is done?from astropy.timeseries import LombScargefrom astropy.timeseries.periodograms import LombScarglelarrybradley commentedon Feb 11, 2019
@bsipocz How about both (using
__init__)? BTW,lombscargeandbtsare both currently subpackages (not modules) understats.bsipocz commentedon Feb 11, 2019
Honestly either way is fine by me, and only pushing to get a decision as then I can update the imports in the astroML textbook (so users don't get deprecation warnings for the new edition).
larrybradley commentedon Feb 11, 2019
@jakevdp should chime in. I don't have a strong opinion.
jakevdp commentedon Feb 13, 2019
Sounds fine either way. Are there plans to add more timeseries functionality? Would Bayesian Blocks go in the timeseries module as well?
bsipocz commentedon Feb 13, 2019
The main part will be the TimeSeries class, and we plan to move the two periodograms. Not sure moving the bayesian blocks would make much sense, they are more generic stats tools then these.
pllim commentedon Apr 17, 2019
I think on Slack, @astrofrog said that he will work on this for 3.2 after #8540 is merged?
astrofrog commentedon Apr 17, 2019
I'll try, I'll try...