You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
4.0 rc1: astropy uses unreleased version of erfa #9654
That is a problem specific for those who use the system's library for erfa: The version in astropy incorporates liberfa/erfa#49, which is not merged or released yet. The function eraSetLeapSeconds() is then used in _erfa/ufunc.c and causes a build failure:
astropy/_erfa/ufunc.c: In function ‘get_leap_seconds’:
astropy/_erfa/ufunc.c:9715:5: error: unknown type name ‘eraLEAPSECOND’
9715 | eraLEAPSECOND *leapseconds;
| ^~~~~~~~~~~~~
astropy/_erfa/ufunc.c:9719:23: warning: implicit declaration of function ‘eraGetLeapSeconds’ [-Wimplicit-function-declaration]
9719 | count = (npy_intp)eraGetLeapSeconds(&leapseconds);
| ^~~~~~~~~~~~~~~~~
astropy/_erfa/ufunc.c:9733:59: error: ‘eraLEAPSECOND’ undeclared (first use in this function); did you mean ‘dt_eraLEAPSECOND’?
9733 | memcpy(PyArray_DATA(array), leapseconds, count*sizeof(eraLEAPSECOND));
| ^~~~~~~~~~~~~
| dt_eraLEAPSECOND
astropy/_erfa/ufunc.c:9733:59: note: each undeclared identifier is reported only once for each function it appears in
astropy/_erfa/ufunc.c: In function ‘set_leap_seconds’:
astropy/_erfa/ufunc.c:9765:9: warning: implicit declaration of function ‘eraSetLeapSeconds’ [-Wimplicit-function-declaration]
9765 | eraSetLeapSeconds(PyArray_DATA(array), PyArray_SIZE(array));
| ^~~~~~~~~~~~~~~~~
It would be great if this is either wrapped with #ifdef so that it remains inactive for the old erfa version (which would require a proper #define in erfa.h, which may anyway a good idea, or to have a new release of erfa that includes the patch. Otherwise, I could also apply the patch to the Debian package.
Activity
pllim commentedon Nov 22, 2019
Hmm... related to #9329 ? cc @mhvk
bsipocz commentedon Nov 22, 2019
I suppose this means we need an erfa release 🤷♀
mhvk commentedon Nov 26, 2019
Fix for
erfaat liberfa/erfa#58pllim commentedon Dec 6, 2019
@olebole , @eteq has released a new version of ERFA (see liberfa/erfa#58 (comment)). Is this now resolved?
olebole commentedon Dec 6, 2019
I just uploaded the new version to Debian unstable, so I am fine with it.
Update python-astropy to rev 8 via SR 761637