Skip to content

Backport light deflection - #10885

Merged
eteq merged 2 commits into
astropy:v4.1.xfrom
mhvk:backport-light-deflection
Oct 19, 2020
Merged

eteq merged 2 commits into
astropy:v4.1.xfrom
mhvk:backport-light-deflection

Conversation

@mhvk

@mhvk mhvk commented Oct 16, 2020

Copy link
Copy Markdown
Contributor

This reverts the earlier attempt to backport #10666, and then adds a single commit that includes corrected versions of #10666 and #10881. This single commit is likely easy to backport to 4.0.

@eteq

eteq commented Oct 16, 2020

Copy link
Copy Markdown
Member

Thanks @mhvk! Lets see how the tests do before I look more closely. But re:

I'm happy to do it more bluntly in v4.1.x itself (i.e., rebase and get rid of your earlier merge instead of reverting it), but we may as well check whether the tests pass.

from #10666, I think it's best to leave this as-is with the revert as that way we don't have to re-write public history. (And it reflects the reality of how this developed anyway!)

@mhvk

mhvk commented Oct 16, 2020

Copy link
Copy Markdown
Contributor Author

@eteq - the failures seem unrelated.

@mhvk

mhvk commented Oct 16, 2020

Copy link
Copy Markdown
Contributor Author

And, yes, good to keep this as is, including the history.

@mhvk

mhvk commented Oct 16, 2020

Copy link
Copy Markdown
Contributor Author

Also: I just checked: the commit backports cleanly to 4.0.x (except the changelog entry, which goes in 4.0.3 for some reason). Shall I push that to 4.0.x directly?

@mhvk mhvk added this to the v4.1 milestone Oct 17, 2020
@eteq

eteq commented Oct 19, 2020

Copy link
Copy Markdown
Member

Thanks for the fixed backport, @mhvk! I see now how intertwined these are but this seems to do it.

Re: v4.0.x, Not yet @mhvk - we should leave that to the next 4.0.x releaser (which I think will be @astrofrog). Also, sorry, but this raises one more question I want to bring back to #10666 (just trying to put the discussion there instead of here so it's all in one place).

To be clear, though, if we do agree to do the 4.0.x backport there, whoever does the backport should backport #10666 and then this, and that should do the trick.

@eteq
eteq merged commit e4c1a34 into astropy:v4.1.x Oct 19, 2020
@mhvk
mhvk deleted the backport-light-deflection branch October 19, 2020 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants