Repository navigation
Conversation
Add topocentric CIRS and fix the CIRS to AltAz transformations
Use EarthLocation instead of GCRS position for TETE observer.
Contributor
Author
|
Now that we understand why the simpler backport didn't work and fixed that, I'll close this really too large late-in-the-game PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@bsiposc - it turned out that the backport of #11061 without #10994 was difficult, but with it straightforward. So, I combined them here and even added a what's new entry, with the logic that #11061 fixes a bug in that our
AltAzwere always off by quite a bit.But I realize this is really not what release candidates are for, so please do feel free to tell me to let things be and keep #11061 for 4.3.