Repository navigation
Allow explicit negative distances in SphericalRepresentation - #11113
Merged
Merged
Conversation
Contributor
Author
|
Approved a few days ago, so I'll go ahead and merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11104, #8091
The problem was that any input
Distancewas turned into aQuantityinstead of just passed through. It really should pass it through, as it is a subclass, so this PR allows it (which is what makes it an API change). But to fix that, a small change had to be made toAngle.__new__to allow it to pass on keyword arguments likesubok=TruetoQuantity.__new__.Also, it turned out
_combine_xyzwas not safe for some operations with this change, but since that private function that was no longer needed anyway now our minimum numpy version is 1.17, so the first commit just turns that into a simplenp.stack.