Repository navigation
What's New entry for threadsafety improvements - #11241
Merged
Merged
Conversation
pllim
reviewed
Jan 12, 2021
Comment on lines
+43
to
+44
| Improvements in making Astropy threadsafe | ||
| ========================================= |
Member
There was a problem hiding this comment.
Suggested change
| Improvements in making Astropy threadsafe | |
| ========================================= | |
| Improvements in making Astropy thread-safe | |
| ========================================== |
| ========================================= | ||
|
|
||
| To help use of Astropy in software for the Square Kilometer Array, an effort | ||
| has started to make Astropy threadsafe for operation that do not explicitly |
Member
There was a problem hiding this comment.
Suggested change
| has started to make Astropy threadsafe for operation that do not explicitly | |
| has been started to make parts of ``astropy`` thread-safe for operations that do not explicitly |
Contributor
Author
There was a problem hiding this comment.
Mostly used - Used "has been started" but replaced "parts of" with "the basic infrastructure of"
| To help use of Astropy in software for the Square Kilometer Array, an effort | ||
| has started to make Astropy threadsafe for operation that do not explicitly | ||
| change state. In particular, parsing of units and angles, and updating | ||
| leap-second tables should now be threadsafe, as should any use of the |
Member
There was a problem hiding this comment.
Suggested change
| leap-second tables should now be threadsafe, as should any use of the | |
| leap-second tables should now be thread-safe, as should any use of the |
Contributor
Author
There was a problem hiding this comment.
Thanks, rephrased slightly.
Member
|
Also cc @bmerry |
bmerry
reviewed
Jan 13, 2021
mhvk
force-pushed
the
whats-new-thread-safety
branch
from
January 13, 2021 21:51
4f8025f to
bffd929
Compare
Contributor
Author
|
OK, rewritten following your comments - thanks, much clearer now! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to be ahead of the game (for once...).
EDIT: Need these to get merged first: