Skip to content

Backport PR #11279 on branch v4.0.x (Switch to Towncrier) - #12075

Merged
eteq merged 2 commits into
astropy:v4.0.xfrom
astrofrog:towncrier-lts
Aug 18, 2021
Merged

eteq merged 2 commits into
astropy:v4.0.xfrom
astrofrog:towncrier-lts

Conversation

@astrofrog

@astrofrog astrofrog commented Aug 17, 2021 •

Copy link
Copy Markdown
Member

Description

This pull request is to manually backport the switching to towncrier to the v4.0.x branch.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the Extra CI label.
  • Is a change log needed? If yes, did the change log check pass? If no, add the no-changelog-entry-needed label.
  • Is a milestone set? Milestone must be set but astropy-bot check might be missing; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate backport-X.Y.x label(s) before merge.

@astrofrog astrofrog added this to the v4.0.6 milestone Aug 17, 2021
@astrofrog
astrofrog changed the base branch from main to v4.0.x August 17, 2021 22:34
@pllim
pllim requested review from Cadair, bsipocz and saimn August 17, 2021 22:42
@astrofrog
astrofrog force-pushed the towncrier-lts branch 3 times, most recently from a70fd90 to b583676 Compare August 18, 2021 11:59

@eteq eteq left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eteq eteq added the zzz 💤 merge-when-ci-passes Do not use: We have auto-merge option now. label Aug 18, 2021
@eteq

eteq commented Aug 18, 2021

Copy link
Copy Markdown
Member

Note the RTD failure is a bug in the way towncrier is generating the new changelog. @astrofrog and I duscussed this on Slack and concluded this needn't block the release because it can be fixed manually in a release tag (just not easily in a non-release commit), but we should fix it when we can (@astrofrog I think is making an issue for this).

@eteq
eteq merged commit 6cb965d into astropy:v4.0.x Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants