Skip to content

Replace metaclass with __init_subclass__ - #12118

Merged
saimn merged 1 commit into
astropy:mainfrom
mhvk:io-fits-replace-metaclass
Sep 1, 2021
Merged

saimn merged 1 commit into
astropy:mainfrom
mhvk:io-fits-replace-metaclass

Conversation

@mhvk

@mhvk mhvk commented Aug 25, 2021 •

Copy link
Copy Markdown
Contributor

Inspired by seeing #7144 float back to the top again.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the Extra CI label.
  • Is a change log needed? If yes, did the change log check pass? If no, add the no-changelog-entry-needed label. If this is a manual backport, use the skip-changelog-checks label unless special changelog handling is necessary.
  • Is a milestone set? Milestone must be set but astropy-bot check might be missing; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate backport-X.Y.x label(s) before merge.

@saimn saimn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mhvk !

@saimn
saimn merged commit ebe28cd into astropy:main Sep 1, 2021
@mhvk
mhvk deleted the io-fits-replace-metaclass branch September 1, 2021 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants