Skip to content

Make OrderedDict into a dict in astropy.io.misc - #12717

Merged
pllim merged 1 commit into
astropy:mainfrom
matteobachetti:patch-3
Jan 11, 2022
Merged

pllim merged 1 commit into
astropy:mainfrom
matteobachetti:patch-3

Conversation

@matteobachetti

@matteobachetti matteobachetti commented Jan 11, 2022 •

Copy link
Copy Markdown
Contributor

This is a very minor change, as per #10888. I hope it will work out of the box. Since Python 3.7, dictionaries are supposed to be ordered, so there shouldn't be a need for OrderedDict anymore.

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the Extra CI label.
  • Is a change log needed? If yes, did the change log check pass? If no, add the no-changelog-entry-needed label. If this is a manual backport, use the skip-changelog-checks label unless special changelog handling is necessary.
  • Is a milestone set? Milestone must be set but astropy-bot check might be missing; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate backport-X.Y.x label(s) before merge.

@github-actions github-actions Bot added zzz 💤 io.misc.asdf archived: Go to asdf-astropy repo time labels Jan 11, 2022
@pllim pllim added this to the v5.1 milestone Jan 11, 2022
@pllim
pllim requested a review from eslavich January 11, 2022 13:42

@pllim pllim left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks uncontroversial enough but I'll give asdf dev a bit of time to comment. Thanks!

@eslavich eslavich left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@pllim
pllim merged commit 386f9be into astropy:main Jan 11, 2022
@matteobachetti
matteobachetti deleted the patch-3 branch January 11, 2022 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants