Skip to content

Add checkbox to PR template for What's new entry - #12813

Merged
pllim merged 1 commit into
astropy:mainfrom
hamogu:checkbox_what_new
Feb 8, 2022
Merged

Add checkbox to PR template for What's new entry#12813
pllim merged 1 commit into
astropy:mainfrom
hamogu:checkbox_what_new

Conversation

@hamogu

@hamogu hamogu commented Feb 3, 2022 •
edited by pllim
Loading

Copy link
Copy Markdown
Member

See #9676 for discussion

Description

This pull request is to address ...

Fixes #

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the Extra CI label.
  • Is a change log needed? If yes, did the change log check pass? If no, add the no-changelog-entry-needed label. If this is a manual backport, use the skip-changelog-checks label unless special changelog handling is necessary.
  • Is this a big PR that makes a What's new entry worthwhile and if so, is a "what's new" entry included in this PR?
  • Is a milestone set? Milestone must be set but astropy-bot check might be missing; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate backport-X.Y.x label(s) before merge.

@hamogu hamogu mentioned this pull request Feb 3, 2022
Closed
@hamogu

hamogu commented Feb 3, 2022

Copy link
Copy Markdown
Member Author

Aarg. Now it fails the bot that checks if a milestone it set, but since this is not code, it's just GH hiddne files that contol the PR template, I think it should not have a milestone.
Too many bots!

@pllim pllim added this to the v5.1 milestone Feb 3, 2022
@pllim

pllim commented Feb 3, 2022

Copy link
Copy Markdown
Member

The milestone bot only appears when it wants to... 🤷

pllim
pllim reviewed Feb 3, 2022
View reviewed changes
Comment thread .github/PULL_REQUEST_TEMPLATE.md Outdated
- [ ] Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see ["When to rebase and squash commits"](https://docs.astropy.org/en/latest/development/when_to_rebase.html).
- [ ] Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the `Extra CI` label.
- [ ] Is a change log needed? If yes, did the change log check pass? If no, add the `no-changelog-entry-needed` label. If this is a manual backport, use the `skip-changelog-checks` label unless special changelog handling is necessary.
- [ ] Is this a big PR that makes a What's new entry worthwhile and if so, is a "what's new" entry included in this PR?

@pllim pllim Feb 3, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also recommend maintainer add the whatsnew-needed label here?

hamogu
hamogu commented Feb 3, 2022
View reviewed changes
Comment thread .github/PULL_REQUEST_TEMPLATE.md Outdated
pllim
pllim approved these changes Feb 3, 2022
View reviewed changes

@pllim pllim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but not sure if you want to keep it open for other reviews. Thanks!

Maybe squash?

Also you can apply [ci skip] to the commit. I don't think we need to run the CI for this.

@hamogu

hamogu commented Feb 3, 2022

Copy link
Copy Markdown
Member Author

I'll leave this open for at least a day or two in case other people want to comment. I'll squish it after that.

@hamogu
hamogu force-pushed the checkbox_what_new branch from ca772c8 to 5e2185e Compare February 4, 2022 01:12
@hamogu hamogu mentioned this pull request Feb 4, 2022
Merged
@pllim

pllim commented Feb 8, 2022

Copy link
Copy Markdown
Member

It's been 5 days. Is it time to squish and merge?

@hamogu

hamogu commented Feb 8, 2022

Copy link
Copy Markdown
Member Author

I already squished / squashed / squashed. Feel free to merge when you feel like it.

@pllim
pllim merged commit 314dbe8 into astropy:main Feb 8, 2022
@pllim

pllim commented Feb 8, 2022

Copy link
Copy Markdown
Member

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pllim pllim pllim approved these changes

Assignees

No one assigned

Labels

Docs no-changelog-entry-needed Release

Projects

None yet

Milestone

v5.1

Development

Successfully merging this pull request may close these issues.

2 participants

@hamogu @pllim