Skip to content

MNT: v5.0.x will not support Python 3.12 - #15331

Merged
pllim merged 1 commit into
astropy:v5.0.xfrom
pllim:no-python3.12-for-you
Sep 20, 2023
Merged

pllim merged 1 commit into
astropy:v5.0.xfrom
pllim:no-python3.12-for-you

Conversation

@pllim

@pllim pllim commented Sep 16, 2023

Copy link
Copy Markdown
Member

Description

This pull request is a companion to #14784 but for v5.0.x.

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@pllim pllim added skip-basebranch-check Skip base branch check for direct backports Python 3.12 labels Sep 16, 2023
@pllim pllim added this to the v5.0.9 milestone Sep 16, 2023
@github-actions

This comment was marked as outdated.

@pllim pllim mentioned this pull request Sep 16, 2023
6 tasks done
@pllim
pllim marked this pull request as ready for review September 16, 2023 19:37
@pllim
pllim requested a review from a team September 16, 2023 19:38

@astrofrog astrofrog left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - in practice this won't stop users from installing the previous 5.0.x version of astropy on Python 3.12 but at least users explicitly trying to install the latest versions will get an informative error.

@pllim
pllim merged commit de6b3ef into astropy:v5.0.x Sep 20, 2023
@pllim
pllim deleted the no-python3.12-for-you branch September 20, 2023 15:40
@pllim

pllim commented Sep 20, 2023

Copy link
Copy Markdown
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

installation Python 3.12 skip-basebranch-check Skip base branch check for direct backports

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants