Repository navigation
Removed OrderedDict from time in formats.py - #15491
Conversation
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
pllim
added
Refactoring
no-changelog-entry-needed
and removed
no-changelog-entry-needed
labels
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to Astropy 👋 and congratulations on your first pull request! 🎉
A project member will respond to you as soon as possible; in the meantime, please have a look over the Checklist for Contributed Code and make sure you've addressed as many of the questions there as possible.
If you feel that this pull request has not been responded to in a timely manner, please send a message directly to the development mailing list. If the issue is urgent or sensitive in nature (e.g., a security vulnerability) please send an e-mail directly to the private e-mail [email protected].
|
👋 Thank you for your draft pull request! Do you know that you can use |
|
|
|
codecov upload for PR can also be flaky and failed here, so I won't worry about the red coverage report either. |
|
I cannot decide if a change log is needed or not so I'll defer to subpackage maintainers. Thanks! |
|
Thanks! Given the impending feature freeze, I took the liberty to push a couple of commits directly here as part of my general review. But I'll leave it to the sub-package maintainers to do a final review. Please squash and merge |
|
Hi! Is there anything more to be done in this issue? I saw that the tests have passed and was wondering if it got left behind! Thanks! |
|
There are conflicts now, so this needs a rebase. While you rebase, squashing commits into one commit would be nice. Thanks! |
|
Hi humans 👋 - this pull request hasn't had any new commits for approximately 4 months. I plan to close this in 30 days if the pull request doesn't have any new commits by then. In lieu of a stalled pull request, please consider closing this and open an issue instead if a reminder is needed to revisit in the future. Maintainers may also choose to add keep-open label to keep this PR open but it is discouraged unless absolutely necessary. If this PR still needs to be reviewed, as an author, you can rebase it to reset the clock. If you believe I commented on this pull request incorrectly, please report this here. |
Removed OrderedDict from astropy/time/formats.py and replaced with dict.
[ci skip]
fd54ce3 to
c3f1575
Compare
taldcroft
left a comment
taldcroft
left a comment
There was a problem hiding this comment.
I rebased and stopped changed dict() to {} per ruff. Thanks @olintoeduardo and sorry for letting this one drop off my radar! Approving now contingent on CI passing.
* Update formats.py Removed OrderedDict from astropy/time/formats.py and replaced with dict. * Create 15491.api.rst * Change comment [ci skip] * Reword change log * Use dict literal --------- Co-authored-by: P. L. Lim <[email protected]> Co-authored-by: Tom Aldcroft <[email protected]>
4 participants
Removed OrderedDict from astropy/time/formats.py and replaced with dict.
Description
This pull request is to address the issue #10888 to remove OrderedDict from the project and replace with dict. This pull request addresses this to the Time module, and simply makes 3 changes to the formats.py file.
Address part of #10888