Skip to content

Removed OrderedDict from io.registry - #15494

Merged
pllim merged 5 commits into
astropy:mainfrom
marcellonascif:remove-ordereddict-io.registry
Oct 23, 2023
Merged

pllim merged 5 commits into
astropy:mainfrom
marcellonascif:remove-ordereddict-io.registry

Conversation

@marcellonascif

@marcellonascif marcellonascif commented Oct 17, 2023 •

Copy link
Copy Markdown
Contributor

Description

This pull request removes OrderedDict from files in io.registry. The files are base.py and core.py.
The OrderedDicts are normal dictionaries now.

Fixes part of #10888

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but we cannot check for it on Actions; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions

Copy link
Copy Markdown
Contributor

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@marcellonascif

Copy link
Copy Markdown
Contributor Author

pre-commit.ci autofix

@marcellonascif
marcellonascif marked this pull request as ready for review October 17, 2023 17:20
@pllim pllim added this to the v6.0 milestone Oct 17, 2023
@marcellonascif

Copy link
Copy Markdown
Contributor Author

Hey! Should I worry about this test which is not successful?

@pllim

pllim commented Oct 18, 2023

Copy link
Copy Markdown
Member

The "dev" failure is unrelated, so no need to worry. 😸

@pllim
pllim requested a review from taldcroft October 18, 2023 16:47

@nstarman nstarman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! These states are never serialized to yaml, so there's no worry about the ordering being lost.

Comment thread docs/changes/io.registry/15494.api.rst Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nstarman , does this really need a change log?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No.

@pllim
pllim enabled auto-merge (squash) October 23, 2023 18:40
@pllim
pllim merged commit 915863c into astropy:main Oct 23, 2023
@pllim

pllim commented Oct 23, 2023

Copy link
Copy Markdown
Member

Thank you, all!

@marcellonascif

Copy link
Copy Markdown
Contributor Author

Thank you guys again! You are helping me a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants