Repository navigation
Removed OrderedDict from io.registry - #15494
Merged
pllim merged 5 commits intoOct 23, 2023
Merged
Conversation
Contributor
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
Contributor
|
👋 Thank you for your draft pull request! Do you know that you can use |
Contributor
Author
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
Contributor
Author
|
Hey! Should I worry about this test which is not successful? |
Member
|
The "dev" failure is unrelated, so no need to worry. 😸 |
nstarman
approved these changes
Oct 23, 2023
nstarman
left a comment
Member
There was a problem hiding this comment.
Thanks! These states are never serialized to yaml, so there's no worry about the ordering being lost.
pllim
reviewed
Oct 23, 2023
pllim
enabled auto-merge (squash)
October 23, 2023 18:40
Member
|
Thank you, all! |
Contributor
Author
|
Thank you guys again! You are helping me a lot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request removes OrderedDict from files in io.registry. The files are base.py and core.py.
The OrderedDicts are normal dictionaries now.
Fixes part of #10888