Skip to content

Removed OrderedDict from tests - #15562

Merged
pllim merged 1 commit into
astropy:mainfrom
marcellonascif:remove-ordereddict-tests.runner
Nov 1, 2023
Merged

pllim merged 1 commit into
astropy:mainfrom
marcellonascif:remove-ordereddict-tests.runner

Conversation

@marcellonascif

Copy link
Copy Markdown
Contributor

Description

This pull request removes OrderedDict from file "runner" in tests.
The OrderedDict is normal dictionary now.

Fixes part of #10888

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but we cannot check for it on Actions; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions

Copy link
Copy Markdown
Contributor

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@pllim pllim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is uncontroversial. Thanks!

@pllim
pllim merged commit 05f7b2c into astropy:main Nov 1, 2023
@marcellonascif

Copy link
Copy Markdown
Contributor Author

thank you @pllim for merging this! ❤️

@pllim

pllim commented Nov 1, 2023

Copy link
Copy Markdown
Member

Thank YOU for contributing! 😸

@marcellonascif

Copy link
Copy Markdown
Contributor Author

@pllim I think that pinning this PR on the initial comment of the issue would be a good idea. Is it right?

@pllim pllim mentioned this pull request Nov 6, 2023
5 of 13 tasks
@pllim

pllim commented Nov 6, 2023

Copy link
Copy Markdown
Member

Yes, thanks for the reminder!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants