Skip to content

Replace OrderedDict with dict in nddata module - #15623

Merged
pllim merged 2 commits into
astropy:mainfrom
felipekhouri:remove-ordereddict-nddata
Nov 27, 2023
Merged

Replace OrderedDict with dict in nddata module#15623
pllim merged 2 commits into
astropy:mainfrom
felipekhouri:remove-ordereddict-nddata

Conversation

@felipekhouri

@felipekhouri felipekhouri commented Nov 16, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Following the discussion in issue #10888, this Pull Request is to replace the usage of OrderedDict with dict in the nddata module. This change is motivated by the fact that, starting from Python 3.7, the standard dictionary (dict) maintains the order of elements, rendering OrderedDict unnecessary.

I have made the necessary replacements and ensured that all functionalities continue to work as expected. Additionally, I have updated the tests to reflect this change.

Fixes one of #10888 tasks.

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@github-actions

github-actions Bot commented Nov 16, 2023

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but we cannot check for it on Actions; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions

github-actions Bot commented Nov 16, 2023

Copy link
Copy Markdown
Contributor

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@felipekhouri felipekhouri changed the title Replaced OrderedDict with dict in nddata module Replace OrderedDict with dict in nddata module Nov 16, 2023
@felipekhouri

felipekhouri commented Nov 16, 2023

Copy link
Copy Markdown
Contributor Author

pre-commit.ci autofix

@pllim pllim added this to the v6.1 milestone Nov 16, 2023
@pllim
pllim requested review from bmorris3 and mwcraig November 16, 2023 13:47
@pllim pllim mentioned this pull request Nov 16, 2023
Open
5 of 13 tasks
@pllim

pllim commented Nov 16, 2023

Copy link
Copy Markdown
Member

Thanks! I cannot decide if this needs a change log or not, so deferring to subpackage maintainers.

@bmorris3

bmorris3 commented Nov 16, 2023

Copy link
Copy Markdown
Contributor

I'd say it does not need a changelog.

@pllim

pllim commented Nov 16, 2023

Copy link
Copy Markdown
Member

I cannot tell if RTD failure is related or not. But if not, it might be resolved by the time this gets out of draft.

@felipekhouri
felipekhouri marked this pull request as ready for review November 20, 2023 19:16
@felipekhouri

felipekhouri commented Nov 26, 2023

Copy link
Copy Markdown
Contributor Author

I don't know why the RTD check failed. Am I missing something? @pllim

bmorris3
bmorris3 approved these changes Nov 27, 2023
View reviewed changes

@bmorris3 bmorris3 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I believe the rtd failure is unrelated.

@pllim

pllim commented Nov 27, 2023

Copy link
Copy Markdown
Member

Yup, RTD failure was caused by scipy doc SSL cert, which has been fixed upstream since. Thanks, merging!

@pllim
pllim merged commit 86272e7 into astropy:main Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bmorris3 bmorris3 bmorris3 approved these changes
@mwcraig mwcraig Awaiting requested review from mwcraig

Assignees

No one assigned

Labels

nddata no-changelog-entry-needed Refactoring

Projects

None yet

Milestone

v6.1.0

Development

Successfully merging this pull request may close these issues.

3 participants

@felipekhouri @pllim @bmorris3