Skip to content

Backport PR #16709 on branch v6.1.x (Reduce duplication of CompoundModel._initialize_slices) - #16762

Merged
pllim merged 1 commit into
astropy:v6.1.xfrom
meeseeksmachine:auto-backport-of-pr-16709-on-v6.1.x
Jul 25, 2024
Merged

pllim merged 1 commit into
astropy:v6.1.xfrom
meeseeksmachine:auto-backport-of-pr-16709-on-v6.1.x

Conversation

@meeseeksmachine

Copy link
Copy Markdown

Backport PR #16709: Reduce duplication of CompoundModel._initialize_slices

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@pllim

pllim commented Jul 23, 2024

Copy link
Copy Markdown
Member

I don't understand why Windows is failing on FITS stuff in this backport.

Also since 6.1.2 is released but @astrofrog plans to do a post-release, I am also not sure on the milestone. 🤷‍♀️

@pllim

pllim commented Jul 23, 2024

Copy link
Copy Markdown
Member

Maybe the Windows failure is not related.

Since Tom R is in the midst of release, I will let him merge.

@pllim
pllim requested a review from astrofrog July 23, 2024 20:07
@astrofrog astrofrog modified the milestones: v6.1.2, v6.1.3 Jul 25, 2024
@pllim
pllim merged commit bbb0c7f into astropy:v6.1.x Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants